Skip to content

[TOOL-3508] Dashboard: Engine general Page UI improvements, update engine instance header layout #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[TOOL-3508] Dashboard: Engine general Page UI improvements, update engine instance header layout #6324

merged 1 commit into from
Feb 27, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 23, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring and enhancing the engine module of the dashboard application. It introduces new components, improves UI elements, and modifies existing functionalities to streamline engine management processes.

Detailed summary

  • Removed unused imports across multiple files.
  • Updated CSS variables for text colors.
  • Enhanced EngineImportPage with improved form handling and validation using zod.
  • Introduced EngineInfoCard and EngineStatusBadge components.
  • Refactored EngineInstancesTable to improve instance management.
  • Added new modals for editing and deleting engine instances.
  • Implemented better state management and routing for engine actions.
  • Improved UI layout and styling for various components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 23, 2025

TOOL-3508 Engine pages UI improvements

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a691fa9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 1:26pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 25, 2025 1:26pm
login ⬜️ Skipped (Inspect) Feb 25, 2025 1:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 25, 2025 1:26pm
wallet-ui ⬜️ Skipped (Inspect) Feb 25, 2025 1:26pm

@vercel vercel bot temporarily deployed to Preview – login February 23, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 23, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 23, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 23, 2025 14:33 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 23, 2025
@MananTank MananTank marked this pull request as ready for review February 23, 2025 14:33
@MananTank MananTank requested review from a team as code owners February 23, 2025 14:33
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (f693ab8) to head (511bb5b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6324   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f693ab8
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.25 KB (0%) 925 ms (0%) 385 ms (+16.11% 🔺) 1.4 s
thirdweb (cjs) 121.91 KB (0%) 2.5 s (0%) 898 ms (+12.81% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 186 ms (+808.7% 🔺) 298 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 33 ms (+356.12% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.31 KB (0%) 387 ms (0%) 116 ms (+146.66% 🔺) 502 ms

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 23, 2025 14:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 23, 2025 14:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 23, 2025 14:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 23, 2025 14:41 Inactive
graphite-app[bot]
graphite-app bot reviewed Feb 23, 2025
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 23, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 23, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 23, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 23, 2025 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 23, 2025 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 23, 2025 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 23, 2025 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 23, 2025 14:48 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 25, 2025 •
edited
Loading

Merge activity

  • Feb 25, 8:18 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 25, 8:26 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

@MananTank
[TOOL-3508] Dashboard: Engine general Page UI improvements, update en…
a691fa9 
…gine instance header layout (#6324)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring and enhancing the `engine` module of the dashboard application. It introduces new components, improves UI elements, and modifies existing functionalities to streamline engine management processes.

### Detailed summary
- Removed unused imports across multiple files.
- Updated CSS variables for text colors.
- Enhanced `EngineImportPage` with improved form handling and validation using `zod`.
- Introduced `EngineInfoCard` and `EngineStatusBadge` components.
- Refactored `EngineInstancesTable` to improve instance management.
- Added new modals for editing and deleting engine instances.
- Implemented better state management and routing for engine actions.
- Improved UI layout and styling for various components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 13:19 Inactive
@jnsdls jnsdls merged commit 39a8afd into main Feb 27, 2025
29 of 30 checks passed
@jnsdls jnsdls deleted the tool-3508 branch February 27, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MananTank @joaquim-verges @jnsdls